Skip to content

fix: CHF nchf-convergedcharging update and release panic#68

Merged
Alonza0314 merged 6 commits into
free5gc:mainfrom
solar224:fix/chf-online-charging-requestedunit-nil-guard
Apr 23, 2026
Merged

fix: CHF nchf-convergedcharging update and release panic#68
Alonza0314 merged 6 commits into
free5gc:mainfrom
solar224:fix/chf-online-charging-requestedunit-nil-guard

Conversation

@solar224

Copy link
Copy Markdown
Contributor
  • Fix CHF panic in converged charging update/release when quotaManagementIndicator=ONLINE_CHARGING but requestedUnit is missing.
  • Add request validation to reject malformed online-charging payloads with a controlled 400 Bad Request (instead of 500/panic).
  • Add defensive nil-guard logic in reservation calculation to prevent nil-pointer dereference even if malformed data bypasses validation.

Fixes: free5gc/free5gc#929

@roundspring2003

Copy link
Copy Markdown
Contributor

@solar224 please help to fix the conflict

@solar224

Copy link
Copy Markdown
Contributor Author

@roundspring2003 PTAL

@roundspring2003

Copy link
Copy Markdown
Contributor

@Alonza0314 test all pass

@Alonza0314
Alonza0314 merged commit 9fa9ec9 into free5gc:main Apr 23, 2026
3 checks passed
@solar224
solar224 deleted the fix/chf-online-charging-requestedunit-nil-guard branch April 23, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bugs] CHF nchf-convergedcharging update and release panic when online-charging MultipleUnitUsage omits requestedUnit

3 participants