Skip to content

fix: CHF panics on wrong ChargingDataRef in partial-record reopen#71

Merged
Alonza0314 merged 1 commit into
free5gc:mainfrom
solar224:fix/chf-convergedcharging-wrong-ref-partial-reopen-guard
Apr 9, 2026
Merged

fix: CHF panics on wrong ChargingDataRef in partial-record reopen#71
Alonza0314 merged 1 commit into
free5gc:mainfrom
solar224:fix/chf-convergedcharging-wrong-ref-partial-reopen-guard

Conversation

@solar224

@solar224 solar224 commented Mar 27, 2026

Copy link
Copy Markdown
Contributor
  • Fixes a panic when a wrong ChargingDataRef is used in partial-record flows.
  • Adds session validation in ChargingDataUpdate: unknown or nil charging-session context returns a controlled 404 ProblemDetails.
  • Removes the unsafe fallback to the latest record and keeps ue.Cdr[chargingSessionId] aligned during partial-record rollover.
  • Hardens OpenCDR(..., partialRecord=true) with defensive nil/session checks.
  • Adds tests.

Fixes: free5gc/free5gc#950

d11nn
d11nn approved these changes Apr 7, 2026
View reviewed changes

@d11nn d11nn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alonza0314 LGTM

Alonza0314
Alonza0314 reviewed Apr 8, 2026
View reviewed changes
Comment thread internal/sbi/processor/converged_charging.go
@Alonza0314
Alonza0314 merged commit dce8ddc into free5gc:main Apr 9, 2026
3 checks passed
@solar224
solar224 deleted the fix/chf-convergedcharging-wrong-ref-partial-reopen-guard branch April 20, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d11nn d11nn d11nn approved these changes
@Alonza0314 Alonza0314 Alonza0314 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bugs] CHF POST /nchf-convergedcharging/v3/chargingdata/{ChargingDataRef}/update panics on wrong ChargingDataRef in partial-record reopen

3 participants

@solar224 @d11nn @Alonza0314