chore(deps): update dependency webpack to v5 - #1306
renovate[bot] wants to merge 2 commits into
Conversation
f2eb384 to
4de3597
Compare
58b118e to
bdf9f9b
Compare
d1837f8 to
25aff2e
Compare
c5d2ecf to
db27532
Compare
8f4f31a to
22f1605
Compare
6a5d86a to
a5f1ec1
Compare
5c85ef3 to
ccdd264
Compare
418b5a4 to
1f40f0d
Compare
e55b878 to
25cd68b
Compare
|
Needs Webpack v4 / #1306 to be merged before this can be updated. |
8e52206 to
af86b05
Compare
|
This will need more investigation. To get this working, we'll need to:
resolve: {
fallback: {
path: require.resolve('path-browserify'),
util: require.resolve('util/')
}
}
Edit: Turns out Webpack <= 4 included some useful polyfills, which were removed in v5. We just have to replace a few to prevent errors in the browser. |
dd78ffe to
5e1a51c
Compare
scissorsneedfoodtoo
left a comment
There was a problem hiding this comment.
Tested locally and everything seems to be working. Tests pass and the bundle size is about the same as it was with Webpack 4.
Will wait for another review before we merge this.
acb350d to
33c1211
Compare
|
Just in case I trigger a rebase and force push from Renovate again, here are the updates we need to get Webpack v5 working:
const path = require('path');
const webpack = require('webpack');
module.exports = function (env = {}) {
const __DEV__ = env.production ? false : true;
const outputPath = path.join(__dirname, 'build/testable-projects-fcc/v1');
return {
mode: __DEV__ ? 'development' : 'production',
entry: './src/index.js',
output: {
library: 'FCC_Global',
path: outputPath,
filename: 'bundle.js'
},
module: {
rules: [
{
test: /\.js$/,
exclude: /node_modules/,
// uses config from .babelrc
loader: 'babel-loader'
},
{
test: /\.css$/,
exclude: /node_modules/,
// creates String for importing into JS
loader: 'css-loader'
},
{
test: /\.html$/,
exclude: /node_modules/,
// creates String for importing into JS
loader: 'html-loader'
}
]
},
plugins: [
new webpack.ProvidePlugin({
Buffer: ['buffer', 'Buffer']
}),
new webpack.ProvidePlugin({
process: 'process/browser'
})
],
resolve: {
fallback: {
path: require.resolve('path-browserify'),
util: require.resolve('util/')
}
}
};
};Not much has changed in |
f38a253 to
9fb0481
Compare
4812ccc to
e63ea49
Compare
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
4.46.0->5.73.0Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.