chore(deps): Bump getrandom from 0.3.4 to 0.4.2 in /bpk-lib - #239
chore(deps): Bump getrandom from 0.3.4 to 0.4.2 in /bpk-lib#239dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [getrandom](https://github.com/rust-random/getrandom) from 0.3.4 to 0.4.2. - [Changelog](https://github.com/rust-random/getrandom/blob/master/CHANGELOG.md) - [Commits](rust-random/getrandom@v0.3.4...v0.4.2) --- updated-dependencies: - dependency-name: getrandom dependency-version: 0.4.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
| # material; version 0.3 reuses the exact `getrandom` already in the production | ||
| # graph (via tempfile), so the feature adds no new crate version. MIT OR Apache-2.0. | ||
| getrandom = { version = "0.3", optional = true } | ||
| getrandom = { version = "0.4", optional = true } |
There was a problem hiding this comment.
On wasm32-unknown-unknown with payload-encryption, this selects getrandom 0.4 while the target-specific declaration still enables wasm_js on getrandom 0.3. The direct getrandom::fill calls can therefore use 0.4 without a supported backend and return Error::UNSUPPORTED, preventing payload keys and nonces from being generated.
| getrandom = { version = "0.4", optional = true } | |
| getrandom = { version = "0.4", optional = true, features = ["wasm_js"] } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: bpk-lib/crates/core/Cargo.toml
Line: 121
Comment:
**Wasm RNG Backend Stays On 0.3**
On `wasm32-unknown-unknown` with `payload-encryption`, this selects getrandom 0.4 while the target-specific declaration still enables `wasm_js` on getrandom 0.3. The direct `getrandom::fill` calls can therefore use 0.4 without a supported backend and return `Error::UNSUPPORTED`, preventing payload keys and nonces from being generated.
```suggestion
getrandom = { version = "0.4", optional = true, features = ["wasm_js"] }
```
How can I resolve this? If you propose a fix, please make it concise.|
Closed by architect ruling (F4 closure, 2026-07-19): these PRs target the legacy main source cut (/bpk-lib + legacy workflow actions), not the cleanroom architecture. The legacy lineage is preserved as-is; Dependabot re-enters deliberately when the Phase 6 workspace and its dependency graph are authoritative, and then only as a candidate generator feeding the qualification law (never auto-merge; Action updates must end as exact 40-hex pins passing the workflow-pinning audit). |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps getrandom from 0.3.4 to 0.4.2.
Changelog
Sourced from getrandom's changelog.
Commits
4d82673Release v0.4.2 (#821)158fdd4build(deps): bump the all-deps group with 3 updates (#818)5b0adccchangelog: fix Motor OS PR link (#816)f19d321changelog: move version links to relevant sections (#815)b83c779Avoid accessingerrnoon unexpected return values. (#810)3d1b151Updater-efito v6 (#814)73c17f7windows: check return value ofProcessPrng(#811)7589557Update Cargo.lock (#809)6dfd5cbUnify lazy types (#804)5e6b022Update Cargo.lock (#806)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Greptile Summary
This PR upgrades the optional random-number dependency used by payload encryption.
Confidence Score: 4/5
Payload encryption on
wasm32-unknown-unknowncan lose access to its random-number backend.Native targets retain a compatible
getrandom::fillAPI. The workspace Rust version satisfies the dependency's new minimum.The WebAssembly feature remains enabled on getrandom 0.3 instead of the selected 0.4 package.
What T-Rex did
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore(deps): Bump getrandom from 0.3.4 t..." | Re-trigger Greptile