Skip to content

fix(justfile): update demo-helios config to journals schema - #14

Merged
heyoub merged 1 commit into
mainfrom
fix/demo-helios-config-schema
Jul 16, 2026
Merged

fix(justfile): update demo-helios config to journals schema#14
heyoub merged 1 commit into
mainfrom
fix/demo-helios-config-schema

Conversation

@heyoub

@heyoub heyoub commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

The demo-helios recipe writes the pre-scale-out workspace config schema (store_path directly under [workspaces.helios]), which the current config parser rejects:

error[config]: unknown field `store_path`, expected one of
`primary_journal`, `journals`, `docs_glob`, `extractor_cmd`, `semantics`

The BatPak scale-out work moved store_path into a per-journal block. This updates the recipe's heredoc to the current schema (matching what texo init generates): primary_journal = "canonical" + a [workspaces.helios.journals.canonical] block.

Scope / caveats

  • 5-line change to one justfile recipe. Docs/tooling only, no source or behavior change.
  • Clean fast-forward off main; no conflicts.
  • Necessary but not sufficient to make demo-helios run end-to-end: the recipe now parses, but the confined LLM extractor still fails on hosts without the bvisor-linux-launcher (and the confinement denies the network the extractor needs). That confinement layer is slated for removal in the BatPak safe-Rust VM rewrite; this fix stands regardless.

Summary by CodeRabbit

  • Configuration
    • Updated the generated Helios workspace configuration to designate the canonical journal explicitly.
    • Preserved documentation and extractor settings at the workspace level.
    • Organized the journal storage path under the canonical journal configuration.

Greptile Summary

This PR updates the demo-helios recipe to use the current journal-based configuration schema.

  • Selects canonical as the primary journal.
  • Moves the existing store path into the canonical journal table.
  • Declares the journal role as canonical.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

T-Rex T-Rex Logs

What T-Rex did

  • The team executed the general-contract-validation-proof to compare pre-change and post-change behavior for a path under workspaces.helios.
  • The pre-change condition exited with code 1 due to an unknown field store_path.
  • The post-change condition exited with code 0 and produced an empty journal, showing store resolution.
  • The reproducible harness created store artifacts, including a .batpak.lock and 000001.fbat, demonstrating journal selection and store resolution.
  • The harness asserted that the old parser error is absent from the after capture.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
justfile Updates the Helios demo configuration to match the parser's journal schema; no issues found.

Reviews (1): Last reviewed commit: "fix(justfile): update demo-helios config..." | Re-trigger Greptile

The demo-helios recipe wrote the pre-scaleout workspace schema
(store_path directly under [workspaces.helios]), which the current
config parser rejects with "unknown field `store_path`, expected one
of `primary_journal`, `journals`, ...". Move store_path into a
[workspaces.helios.journals.canonical] block and point the workspace
at it via primary_journal = "canonical", matching what `texo init`
now generates.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The demo-helios recipe now generates a workspace configuration with a canonical primary journal, workspace-level documentation and extractor settings, and journal-level storage configuration.

Changes

Helios configuration

Layer / File(s) Summary
Canonical journal configuration
justfile
The generated TOML adds primary_journal = "canonical", retains docs_glob and extractor_cmd at workspace scope, and moves store_path into the canonical journal table with role = "canonical".

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the demo-helios justfile config to the journals schema.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/demo-helios-config-schema

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@heyoub
heyoub merged commit 48e9a6f into main Jul 16, 2026
4 checks passed
@heyoub
heyoub deleted the fix/demo-helios-config-schema branch July 16, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant