fix(justfile): update demo-helios config to journals schema - #14
Merged
Conversation
The demo-helios recipe wrote the pre-scaleout workspace schema (store_path directly under [workspaces.helios]), which the current config parser rejects with "unknown field `store_path`, expected one of `primary_journal`, `journals`, ...". Move store_path into a [workspaces.helios.journals.canonical] block and point the workspace at it via primary_journal = "canonical", matching what `texo init` now generates. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe ChangesHelios configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
demo-heliosrecipe writes the pre-scale-out workspace config schema (store_pathdirectly under[workspaces.helios]), which the current config parser rejects:The BatPak scale-out work moved
store_pathinto a per-journal block. This updates the recipe's heredoc to the current schema (matching whattexo initgenerates):primary_journal = "canonical"+ a[workspaces.helios.journals.canonical]block.Scope / caveats
main; no conflicts.demo-heliosrun end-to-end: the recipe now parses, but the confined LLM extractor still fails on hosts without thebvisor-linux-launcher(and the confinement denies the network the extractor needs). That confinement layer is slated for removal in the BatPak safe-Rust VM rewrite; this fix stands regardless.Summary by CodeRabbit
Greptile Summary
This PR updates the
demo-heliosrecipe to use the current journal-based configuration schema.canonicalas the primary journal.canonical.Confidence Score: 5/5
This looks safe to merge.
No blocking issues found in the changed code.
What T-Rex did
Important Files Changed
Reviews (1): Last reviewed commit: "fix(justfile): update demo-helios config..." | Re-trigger Greptile