fix: fixed nested values in 'fields' query parameter#121
Open
sibuk-harabudjasim wants to merge 1 commit intofreeconf:masterfrom
Open
fix: fixed nested values in 'fields' query parameter#121sibuk-harabudjasim wants to merge 1 commit intofreeconf:masterfrom
sibuk-harabudjasim wants to merge 1 commit intofreeconf:masterfrom
Conversation
Collaborator
|
love all the commits! want to give them the time they deserve for review, but shouldn't be an issue |
Author
|
No worries, I've switched to forked version for my needs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix solves problem when using "fields" query parameter and trying to fetch fields 2 levels deeper than target path.
For example in model:
request
/restconf/data/m:aaa?fields=bbb/cccwill crash with panic "illegal call : base was not found to be any parent of candidate" because "fields" segments length is bigger than current candidate and this case was not covered in code.