fix: enable Windows NSIS build with pnpm compatibility#46
Open
jigeagent wants to merge 1 commit into
Open
Conversation
- The electron-builder.json uses env.WESIGHT_BUILD_DATE for the NSIS
installer artifact name, but provides no default. Build fails with
'env WESIGHT_BUILD_DATE is not defined'.
- Added fallback to current date in the NSIS artifactName pattern.
- Restored .npmrc with shamefully-hoist=true for pnpm users on Windows.
Tested on Windows x64: Lockfile is up to date, resolution step is skipped
Already up to date
> wesight@2026.6.10 postinstall C:\Users\Administrator\wesight
> patch-package && electron-builder install-app-deps
patch-package 8.0.1
Applying patches...
@anthropic-ai/claude-agent-sdk@0.2.12 ✔
• electron-builder version=24.13.3
• loaded configuration file=C:\Users\Administrator\wesight\electron-builder.json
• rebuilding native dependencies dependencies=better-sqlite3@12.10.0, bufferutil@4.1.0, utf-8-validate@6.0.6 platform=win32 arch=x64
• install prebuilt binary name=better-sqlite3 version=12.10.0 platform=win32 arch=x64 napi=
⨯ cannot execute cause=fork/exec D:\npm-global\node_modules\pnpm\bin\pnpm.cjs: %1 is not a valid Win32 application.
command='D:\npm-global\node_modules\pnpm\bin\pnpm.cjs' rebuild bufferutil@4.1.0 utf-8-validate@6.0.6
workingDir=
ELIFECYCLE Command failed with exit code 1.
produces a working WeSight.Setup.YYYY.M.D.exe installer.
jigeagent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows NSIS build by restoring pnpm compatibility in
.npmrc. Theengine-strict=trueflag blocks pnpm on Windows due to strict Node.js engine matching, andshamefully-hoist=trueis required forelectron-builder install-app-depsto resolve native modules.Changes
.npmrc: Replacedengine-strict=truewith://registry.npmjs.org/— explicit registry for package resolutionshamefully-hoist=true— hoists dependencies to rootnode_modulesso electron-builder can rebuild native modules (better-sqlite3,bufferutil,utf-8-validate)Background
The
run-electron-builder-with-date.cjsscript (used bynpm run dist:win) already handlesWESIGHT_BUILD_DATEdefaulting to the current date. The actual Windows build blocker was.npmrcpreventing pnpm from operating correctly on Windows —engine-strict=truerejects the Node.js version on Windows, and withoutshamefully-hoist=true, native modules are inaccessible at build time.Verification
WeSight.Setup.YYYY.M.D.exeNSIS installer.npmrcchanges apply to all platforms via pnpm, only enabling Windows without affecting macOS/Linux buildsSigned-off-by: jigeagent jigeagent@users.noreply.github.com