Fill missing aggregated values #228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Copilot started reviewing on behalf of
Mohammad-Tayyab-Frequenz
December 22, 2025 14:57
View session
There was a problem hiding this comment.
Pull request overview
This pull request adds functionality to fill missing values in aggregated component columns by summing their corresponding individual component data. The implementation automatically backfills NaN values in aggregate columns (e.g., battery_power_flow, pv_asset_production) by computing sums from labeled component columns (e.g., Battery #1, PV #1).
Key changes:
- Introduces
fill_aggregated_component_columns()helper function with configurable component type filtering - Integrates the filling logic into the energy report DataFrame creation pipeline with an optional flag
- Adds comprehensive test coverage for both basic filling behavior and component type filtering
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/frequenz/lib/notebooks/reporting/utils/helpers.py |
Adds new fill_aggregated_component_columns() function that fills missing aggregate values by summing individual component columns |
src/frequenz/lib/notebooks/reporting/data_processing.py |
Integrates the new filling function into create_energy_report_df() with a fill_missing_values parameter (defaults to True) |
tests/test_helpers.py |
Adds two test cases validating the backfill logic and component type filtering behavior |
RELEASE_NOTES.md |
Documents the new feature in the release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
Mohammad-Tayyab-Frequenz
force-pushed
the
fill-missing-aggregated-values
branch
from
17501b5 to
29b038b
Compare
cwasicki
reviewed
Dec 23, 2025
| DataFrame with missing aggregated component columns filled in by summing | ||
| the corresponding individual component columns. | ||
| """ | ||
| # Mapping configuration |
Contributor
There was a problem hiding this comment.
This mapping is probably not specific to only this function, so should be passed in as an argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality to fill missing values in aggregated component columns by summing their corresponding individual component data. The implementation automatically backfills NaN values in aggregate columns (e.g., battery_power_flow, pv_asset_production) by computing sums from labeled component columns (e.g., Battery #1, PV #1).
Key changes: