Skip to content

chore(deps): security updates — grpc, docker/cli, edwards25519 - #125

Merged
samof76 merged 2 commits into
freshworks-oss:mainfrom
arun-k-bharathan:deps/security-updates
Aug 12, 2026
Merged

chore(deps): security updates — grpc, docker/cli, edwards25519#125
samof76 merged 2 commits into
freshworks-oss:mainfrom
arun-k-bharathan:deps/security-updates

Conversation

@arun-k-bharathan

@arun-k-bharathan arun-k-bharathan commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Consolidated replacement for three stale security-related Dependabot PRs:

  • google.golang.org/grpc 1.74.2 → 1.82.1
  • github.com/docker/cli 27.4.1+incompatible → 29.2.0+incompatible
  • filippo.io/edwards25519 1.1.0 → 1.1.1

grpc goes to 1.82.1 rather than the 1.79.3 Dependabot proposed. 1.79.3 predates the fix for GO-2026-6061 (GHSA-hrxh-6v49-42gf), which govulncheck reports as reachable here through grpcurl. Taking 1.82.1 also means bumping the go directive from 1.25 to 1.25.0, since that is what grpc's own go.mod now declares.

The docker/cli bump is a major version jump: it swaps github.com/docker/docker for moby/moby/api and moby/moby/client. This is not confined to the test binary, since internal/psql/utils.go is non-test source and imports ory/dockertest/v3, which puts docker/cli in the build graph of lg itself. The swap also takes github.com/docker/docker out of go.mod and out of the import graph, which clears GO-2026-5668, GO-2026-4887 and GO-2026-4883. All three are reachable on main through dockertest.init, and all three report Fixed in: N/A, so staying on the old module path leaves no way to close them.

Overall govulncheck ./... drops from 14 reachable vulnerabilities on main to 9 on this branch. The 9 that remain have nothing to do with grpc, docker or edwards25519, and #126 handles them.

Source changes

go.mod and go.sum, plus one test fix. The interop/grpc_testing proto that grpc vendors gained a fillPeerSocketAddress field on ResponseParameters in 1.82.1, so it now shows up in --template output for the three streaming methods. I updated the expected-JSON assertions in internal/grpc/grpc_test.go (TestGRPC/CommandlineTemplate/Using_Server_Reflection) to match. The sibling Using Proto File subtest reads this repo's own testing/test.proto, so it needed no change.

Supersedes

Please close these after merging.

Test plan

  • go build ./...
  • make test (go test -count=1 -race ./...), the full suite including the Docker-backed integration tests for cql, lua, psql, mongo and kafka
  • govulncheck ./... no longer reports GO-2026-6061, GO-2026-5668, GO-2026-4887 or GO-2026-4883
  • make lint matches the main baseline (238 pre-existing findings, none new)
  • CI on this PR

Related

The rest of the same cleanup, split up to keep each review small. I'd suggest merging in this order, which is not the order they were opened: this PR, then #126, #127, #128.

- google.golang.org/grpc 1.74.2 -> 1.79.3
- github.com/docker/cli 27.4.1+incompatible -> 29.2.0+incompatible
- filippo.io/edwards25519 1.1.0 -> 1.1.1

Supersedes dependabot PRs freshworks-oss#121, freshworks-oss#120, freshworks-oss#119,
and the now-obsolete freshworks-oss#114 (grpc 1.77.0).
The original 1.79.3 target for this PR does not fix GO-2026-6061
(GHSA-hrxh-6v49-42gf), a high-severity advisory affecting
google.golang.org/grpc/internal/transport (ClientStream methods,
which this codebase reaches as a gRPC client) for all versions
before 1.82.1. Confirmed with `govulncheck ./...` before and after.

Bumping past 1.82.1 also requires `go 1.25.0` exactly, which is why
the go.mod `go` directive changed from `1.25` to `1.25.0`.

Fixes internal/grpc/grpc_test.go: the vendored
google.golang.org/grpc/interop/grpc_testing proto gained a new
`fillPeerSocketAddress` field on ResponseParameters between 1.79.3
and 1.82.1, so the "Using Server Reflection" template test needed
its expected JSON updated to match. The "Using Proto File" subtest
is unaffected since it reflects against this repo's own
testing/test.proto, not the grpc-go interop proto.

@samof76 samof76 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samof76
samof76 merged commit 3e5a79e into freshworks-oss:main Aug 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants