Repository navigation
Per-sport notification settings; alerts only to their sport's app - #465
Merged
Merged
Conversation
Owner: each app controls its own notification settings ("I may want NFL and not college"), and
notifications only go to the proper app for that sport. NotificationPreferences becomes one row
per (user, sport); migration copies existing rows to CFB so nobody's alerts change. The dispatcher
reads the alert sport's settings and sends only to that sport's app (reverts #463's fallback).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DAWjtJgXaMYbzZXYJjTEYs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Backend Unit Test Results✔️ Tests 1219 / 1219 - passed in 31.1s |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner's rules: each app (NFL host / CFB host) has its own notification settings, and notifications only go to the proper app for that sport.
NotificationPreferencesis now one row per (user, sport), with a unique index on (UserId, Sport). The migration copies each existing row to CFB, so nobody's alerts change. Tested on local Postgres: the copy is correct and Down rolls back cleanly.GET/PUT /api/notifications/preferences?sport=0|1. Each app's Notifications page reads and saves its own sport and says which app the settings apply to.Tests: service per-sport isolation, the controller sport param, dispatcher strict routing and per-sport settings, the page loading and saving its sport. Backend 1225 passed (plus the pre-existing live-ESPN failure), frontend 809, notification e2e specs pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DAWjtJgXaMYbzZXYJjTEYs