Repository navigation
Raise backend coverage gate to 68%; validate subscription sport - #473
Merged
Merged
Conversation
#471: backend coverage gate 30% -> 68% (baseline 72.2% lines). #462: reject a push subscription sport other than 0 (NFL) / 1 (CFB) with 400. Closes #471 Closes #462 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DAWjtJgXaMYbzZXYJjTEYs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…d-sport-validation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #471, closes #462.
coverage-threshold30 → 68 in ci.yml, a few points under the current 72.2% line coverage (same approach as the frontend thresholds from Remove Codecov upload; gate frontend coverage in-repo #470). This PR's own CI run proves it passes.POST /api/notifications/subscribereturns 400 for a sport other than 0 (NFL) or 1 (CFB), with a controller test. Previously an undefined value was stored and never matched a push.🤖 Generated with Claude Code
https://claude.ai/code/session_01DAWjtJgXaMYbzZXYJjTEYs