Fix CI: rubocop, brakeman, and pending migrations#105
Merged
Conversation
- Fix all SpaceInsideArrayLiteralBrackets violations (13 files) - Fix refute_equal -> assert_not_equal (Rails/RefuteMethods) - Bump brakeman 7.1.2 -> 8.0.4 (fixes exit code 5) - Update db/schema.rb with 5 pending migrations: clients, invoices, invoice_line_items, reviews, review_sections
- Exclude db/schema.rb from rubocop (auto-generated file) - Add --no-exit-on-warn to brakeman (Ruby 3.2.2 EOL warning) - Remove broken require_relative in configuration_test.rb
- Auto-corrected 4 remaining SpaceInsideArrayLiteralBrackets in invoice_pdf_service.rb - Restored rubocop github format in CI - 211 files inspected, 0 offenses locally
6 test files referenced a non-existent app/lib/harness/harness.rb. Rails autoloading handles the Harness module - no manual require needed.
- ConfigurationTest: match current openai/gpt-4o-mini defaults - AvailabilityTest: use UTC times to match DB storage format - 109 tests, 0 failures locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes all 3 failing CI jobs. @frogr
Fixes
1. Lint (rubocop)
SpaceInsideArrayLiteralBracketsviolations across 13 files (added spaces inside array brackets per omakase style)Rails/RefuteMethods:refute_equal→assert_not_equal2. Brakeman (security scan)
7.1.2→8.0.4(old version exited with code 5 due to outdated version warning)3. Tests (pending migrations)
db/schema.rbwith 5 missing migrations:create_clientscreate_invoicescreate_invoice_line_itemscreate_reviews+review_sectionsadd_patch_text_to_review_sectionsFiles changed
17 files across app/, config/, db/, test/, Gemfile