Repository navigation
Conversation
* feat: add Playwright E2E test suite covering critical workflows * fix: make credit card invoice due-status test deterministic * fix: avoid incomplete regex escaping in dashboard nav E2E test
# Conflicts: # tests/transactions-actions.test.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Remaining Grupo A leftovers from the bisection plan — PII encryption subset already landed in db37a25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vercel Speed Insights showed
/dashboardas the only route failing Core Web Vitals in production (LCP ~4.8s, FCP ~4s, CLS 0.2 "Needs Improvement") while every other route was "Great". Root-caused to four issues isolated to that route and fixed them:Also audited Supabase connection practices per request: confirmed PostgREST-over-HTTP (no connection-pool concern), userContext reused across the fan-out (no repeated auth calls), and that the double getClaims()+getUser() check in getUserContext is intentional defense-in-depth, not redundant. Flagged (not fixed, out of scope) that calculate_total_saved RPC does an unbounded full-history scan, called 2x per load — fine today, will need revisiting if transaction history grows very large.
As a side effect of touching lib/finance/transactions.ts, fixed 3 pre-existing wall-clock-dependent test flakes (UTC-vs-local and month-end clamping edge cases) in transactions-reports.test.ts, transactions-queries.test.ts, and transaction-form.test.tsx.
Type of Change
Testing
npm run lintnpm run buildnpm audit --audit-level=moderateSupabase / Database
supabase/migrationsSecurity Checklist
user_metadatais not used for authorization decisionsNotes
Net diff vs main: app/dashboard/page.tsx, lib/finance/transactions.ts, and the 3 associated test files. No behavior change for /transactions or /payments — listTransactions's public signature is untouched, only fetchDashboardTransactionSets was refactored internally.