Repository navigation
fix: use theme-aware bg-muted for subscription icon background - #67
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes subscription icon background not adapting to light/dark theme by replacing static
bg-accentwith theme-awarebg-muted.Root cause: The subscription icon container used
bg-accent, but the--accentCSS variable is hardcoded as#2a3038in both:root(light mode) and.dark(dark mode). This meant the icon background stayed dark-gray regardless of theme, creating poor contrast in light mode.Solution: Replaced
bg-accentwithbg-muted, which is properly theme-aware:#f5f0e8(light neutral background)#252b31(dark neutral background)This matches the semantic use of other neutral backgrounds in the dashboard and follows the existing theme-token pattern used throughout the app.
Changes:
components/dashboard/subscriptions-tab.tsx: Changed icon container frombg-accenttobg-mutedcomponents/dashboard/__tests__/subscriptions-tab.test.tsx: Added test verifying the component usesbg-mutedinstead ofbg-accentType of Change
Testing
pnpm run lint— passespnpm run build— passespnpm run test— passes (subscriptions-tab theme adaptation test)Supabase / Database
supabase/migrationsSecurity Checklist
user_metadatais not used for authorization decisionsNotes
The fix ensures consistent theme adaptation across all icon chip backgrounds in the dashboard. No visual behavior change in dark mode (which already used a light background via transparency); light mode now properly adapts to the lighter theme.