[Repo Assist] eng: enable package validation (#259)#315
Merged
Conversation
Add EnablePackageValidation=true to the library project. This activates the .NET SDK's built-in package validation on every build, catching package structure problems early (e.g. missing frameworks, mismatched assemblies across TFMs). A commented-out PackageValidationBaselineVersion property is included as a guide for enforcing binary-compatibility checks against a previously- published version. Uncomment and set to e.g. '0.4.0' (or the most recently published version) to have the build fail if any public API is removed or signature-changed. Build verified: 0 warnings, 0 errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is a draft PR from Repo Assist, an automated AI assistant.
Closes #259.
What changed
Added
(EnablePackageValidation)true(/EnablePackageValidation)toFSharp.Control.TaskSeq.fsproj. This activates the .NET SDK's built-in [Package Validation]((devblogs.microsoft.com/redacted) on every build.With this setting alone, the build verifies that the produced
.nupkgis well-formed — no missing framework assets, no framework-specific assemblies that diverge from each other, etc.Enabling baseline binary-compatibility checks
A commented-out property is included as a guide:
``` Uncomment this (or set it to the most recently published version, e.g. `0.5.0`) to have the build **fail if any public API is removed or its signature changed** compared to the specified baseline. This is the main feature requested in #259 — it prevents accidental binary-breaking changes going forward. > **Note**: Baseline validation downloads the baseline package from NuGet at build time, so CI machines need NuGet access. The PR leaves this commented out so the baseline can be set explicitly by a maintainer when ready. ## Test Status Build verified locally (Linux, .NET SDK 10.0.102): ``` Build succeeded. 0 Warning(s) 0 Error(s)No code changes — only
FSharp.Control.TaskSeq.fsprojupdated.