Skip to content

[Repo Assist] eng: enable package validation (#259)#315

Merged
dsyme merged 2 commits intomainfrom
repo-assist/eng-package-validation-2026-03-5f77cbb7e5aed611
Mar 8, 2026
Merged

[Repo Assist] eng: enable package validation (#259)#315
dsyme merged 2 commits intomainfrom
repo-assist/eng-package-validation-2026-03-5f77cbb7e5aed611

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 8, 2026

🤖 This is a draft PR from Repo Assist, an automated AI assistant.

Closes #259.

What changed

Added (EnablePackageValidation)true(/EnablePackageValidation) to FSharp.Control.TaskSeq.fsproj. This activates the .NET SDK's built-in [Package Validation]((devblogs.microsoft.com/redacted) on every build.

With this setting alone, the build verifies that the produced .nupkg is well-formed — no missing framework assets, no framework-specific assemblies that diverge from each other, etc.

Enabling baseline binary-compatibility checks

A commented-out property is included as a guide:

```

Uncomment this (or set it to the most recently published version, e.g. `0.5.0`) to have the build **fail if any public API is removed or its signature changed** compared to the specified baseline. This is the main feature requested in #259 — it prevents accidental binary-breaking changes going forward.

> **Note**: Baseline validation downloads the baseline package from NuGet at build time, so CI machines need NuGet access. The PR leaves this commented out so the baseline can be set explicitly by a maintainer when ready.

## Test Status

Build verified locally (Linux, .NET SDK 10.0.102):

```
Build succeeded.
    0 Warning(s)
    0 Error(s)

No code changes — only FSharp.Control.TaskSeq.fsproj updated.

Generated by Repo Assist ·

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@5029c9574c7bd2baa70aab6c8de9ea09edf11803

Add EnablePackageValidation=true to the library project. This activates
the .NET SDK's built-in package validation on every build, catching
package structure problems early (e.g. missing frameworks, mismatched
assemblies across TFMs).

A commented-out PackageValidationBaselineVersion property is included as
a guide for enforcing binary-compatibility checks against a previously-
published version. Uncomment and set to e.g. '0.4.0' (or the most
recently published version) to have the build fail if any public API is
removed or signature-changed.

Build verified: 0 warnings, 0 errors.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dsyme dsyme marked this pull request as ready for review March 8, 2026 13:13
@dsyme dsyme merged commit a057959 into main Mar 8, 2026
4 checks passed
@dsyme dsyme deleted the repo-assist/eng-package-validation-2026-03-5f77cbb7e5aed611 branch March 8, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding Package Validation to document binary compatibility

1 participant