Skip to content

integrate tenca code into myHPI#621

Open
jeriox wants to merge 8 commits intomainfrom
merge-tenca
Open

integrate tenca code into myHPI#621
jeriox wants to merge 8 commits intomainfrom
merge-tenca

Conversation

@jeriox
Copy link
Copy Markdown
Contributor

@jeriox jeriox commented Sep 10, 2024

Because of better maintainability and expandability, we wanted to integrate the tenca code into myHPI.

ToDo:

  • create view that serves templates
  • move tests
  • do actual testing with mailman

@jeriox jeriox added [T] refactor mailing lists Concerning tenca / mailing list management labels Sep 10, 2024
@frcroth
Copy link
Copy Markdown
Contributor

frcroth commented Sep 11, 2024

Would an alternative be to move/fork tenca to the FSR org? Keeping this project small was one of the design goals at the beginning IIRC

@lukasrad02
Copy link
Copy Markdown
Contributor

The rationale behind this decision was that it is cumbersome to apply changes in two repos that depend on each other if there is no need to separate the code. tenca is a very specialized library and most likely nobody but us is using it. So there is no actual benefit from publishing it as a separate library.

Adding a new feature to our mailing lists (for example #582 that I did recently) currently requires you to set up an editable installation of tenca in you venv, apply your changes to the tenca and myHPI source, then have your changes at tenca reviewed, wait for a new tenca version to be released, until you can finally submit a ready-to-merge PR to myHPI with the new tenca version in the dependencies. Including tenca in the myHPI source tree makes this much easier.

Comment thread myhpi/tenca_django/templates/mailman/unsubscription_message.html Outdated
Comment thread myhpi/tenca_django/mailinglist.py Outdated
@jeriox jeriox marked this pull request as ready for review September 13, 2024 10:05
Comment thread myhpi/tenca_django/mailinglist.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mailing lists Concerning tenca / mailing list management [T] refactor

Development

Successfully merging this pull request may close these issues.

4 participants