Skip to content

Update dependencies to fix machine translation#674

Merged
just-spafi merged 8 commits intomainfrom
fix-machine-translation
Mar 31, 2026
Merged

Update dependencies to fix machine translation#674
just-spafi merged 8 commits intomainfrom
fix-machine-translation

Conversation

@just-spafi
Copy link
Copy Markdown
Contributor

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 12, 2026

Pull Request Test Coverage Report for Build 23796069142

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 74.525%

Totals Coverage Status
Change from base Build 18196927833: -0.02%
Covered Lines: 1726
Relevant Lines: 2316

💛 - Coveralls

@just-spafi just-spafi force-pushed the fix-machine-translation branch 2 times, most recently from d3807e3 to 840feba Compare February 12, 2026 13:26
@lukasrad02
Copy link
Copy Markdown
Contributor

I'm not really happy with a "fix machine translation" PR to also perform a major Wagtail upgrade and update linters and formatters (and thus also apply several changes to the code), especially since in the past we frequently had severe issues after major Wagtail upgrades

@just-spafi
Copy link
Copy Markdown
Contributor Author

The translation was not working because Deepl made changes to their API we had to update wagtail localize to a newer version (briefly described in #673).
But I guess if the wagtail major version made problems in the past we could just update wagtail localize, according to Pypi it should also work with the old wagtail version.

@lukasrad02
Copy link
Copy Markdown
Contributor

we could just update wagtail localize.

Yes, that's what I wanted to imply

@lukasrad02
Copy link
Copy Markdown
Contributor

Even after 0ebfbc4, the lockfile still contains more changes than it should, but I won't care about this, since no major versions have been changed, so everything should still be compatible.

However, I noticed a bug regarding translations after the update: Clicking the "Translate" button activates the text box for the wrong snippet. Working with the dummy data (python manage.py create_test_data), when I try to translate the page title of the /de/information/first-semester/ page, one of the links at the bottom gets edited instead:

myhpi.webm

I think this is related to #614, since the translated string is inserted into the heading anchor on the page

@just-spafi just-spafi requested a review from styrix560 March 31, 2026 11:55
Removed commented-out setup for PostgreSQL in CI workflow.
Copy link
Copy Markdown

@styrix560 styrix560 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test, but code looks good given that we only reverted one commit and updated some other stuff.

@just-spafi just-spafi dismissed lukasrad02’s stale review March 31, 2026 12:05

account not available right now :c

Copy link
Copy Markdown

@Belissimo-T Belissimo-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me
I don't get why half of the displayed changes are poorly formatted layout/whitespace diffs

@just-spafi just-spafi merged commit 0a8e05a into main Mar 31, 2026
5 checks passed
@just-spafi just-spafi deleted the fix-machine-translation branch March 31, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants