Repository navigation
[oss] Add read-only jevbench validate-data subcommand - #209
Merged
Merged
Conversation
Loads files with the canonical loader (runs Task.validate()) and checks unique ids, allowed question kinds, expected-answer type per kind and group consistency. Exits 1 on any problem. Tests use invented fixtures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W43cN22Vpksq7669pf5f5K
Owner
Author
|
Thanks — Harold has logged this for review. Contributor text and code are treated as untrusted data; no external code was run on the benchmark host.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
jevbench/validate_data.py(new): read-only checks over task JSONL files. It loads each line withTask.from_dictfromjevbench/tasks.py, the same pathload_jsonluses, so every task'svalidate()runs. A bad line is reported withfile:lineand loading moves on to the next line, so you see every problem in one run instead of only the first. On top ofvalidate()it checks:question.typeis an allowed kind (QUESTION_TYPES: noul/choice/score)expectedhas the type its kind needs: an int forscore(a bool is rejected),"no"/"yes"fornoul, a label string forchoice.None(unmeasured) is allowed.tests/test_protocol.py::test_public_suite_pairs: all items that share agroupmust sharestr(expected)PROBLEMline per issue and anOK/FAILtotal. It exits 1 on any problem.jevbench/cli.py: registers thevalidate-data PATH...subcommand. It is 12 added lines and nothing existing changed.tests/test_validate_data.py(new): 6 tests that use tiny invented fixtures (fake-*ids, placeholder text) written to a temp dir.CONTRIBUTING.md: a short "Checking task files" section.The diff is 4 files, +224 lines. No changes to
datasets/,results/, scoring, constants or published numbers.Verification
Before (on
main,python -m pytest -q):After:
python -m jevbench.cli validate-data datasets/public/*.jsonl:It found no problems in the public data, and the data was not touched.
Open doubts / conservative choices
question.type. I did not also checkfamilyagainstjevbench.FAMILIES+HARD_FAMILIES. The easy tier usesfactandtool_selection, which are in neither tuple, so that check would flag published data. If those families should be registered, that is a maintainer decision.hard.jsonlhas exactly one item. Groups are pooled across all files given; the public files share no group names.Task.validate()when the line loads. The separate kind check is there as a backstop.🤖 Generated with Claude Code
https://claude.ai/code/session_01W43cN22Vpksq7669pf5f5K
Generated by Claude Code