Repository navigation
Return keyboard focus after an action, and document two README gaps - #10
Merged
Merged
Conversation
Every action runs through runExclusive, which disables the action buttons while it works. Disabling the focused button dropped keyboard focus to the page, so after Scan folder, Make preview sheets, Make cover or Upscale images a keyboard user was back at the top. Focus now returns to the button that started the action, unless it was moved elsewhere in the meantime. Checked in Chromium: by keyboard it comes back with its focus ring, by mouse without one, as before. The README gains two things it was missing: scan-folder's available_subfolders field, and that upscaling again replaces its earlier files, where sheets are never overwritten. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FtCFQJ6wEFf5pZSL2HSE8G
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
runExclusive, which every action goes through, now returns focus to the button that started the action, unless focus was moved somewhere else in the meantime.POST /api/jobs/scan-foldernow listsavailable_subfolders, which was missing: the folders inside a folder with no images of its own. Since Browse for folders, upscale images, and skip macOS metadata files #9 these leave out hidden folders,__MACOSXand---Created---.Testing
ruff check .;pytest(194 tests), including a new test pinning the focus return.mainbefore this change, focus ended on the page body every time.🤖 Generated with Claude Code
https://claude.ai/code/session_01FtCFQJ6wEFf5pZSL2HSE8G
Generated by Claude Code