chore: resolve GH security findings and refresh dependencies#113
Merged
Conversation
Updated Dependabot configuration to include Composer, NPM, and GitHub Actions with specified schedules and update types.
add dependabot auto version bumping
Contributor
|
✅ Playwright report published: https://fuermenschen.github.io/hfm/pr-113/ |
373f66c to
d0c7932
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses GitHub security findings and improves update/CI reliability by hardening workflows and refreshing PHP/npm dependencies, including adjustments for safer frontend hash navigation and cross-platform E2E execution.
Changes:
- Mitigates a CodeQL DOM-XSS finding by replacing hash-based
querySelectorwithgetElementByIdand safe decoding. - Refreshes PHP and npm dependencies (lockfiles) and updates automation around audits/lockfile consistency.
- Improves CI portability and least-privilege defaults (workflow permissions; Windows/Unix-safe E2E Artisan execution).
Reviewed changes
Copilot reviewed 34 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| resources/js/app.js | Reworks hash scroll logic to avoid selector injection (safer ID lookup). |
| e2e/admin-pages.spec.mjs | Uses argument-based php artisan execution for cross-platform E2E stability. |
| composer.lock | Updates PHP dependency lockfile to patched/newer versions. |
| package-lock.json | Updates npm dependency lockfile (incl. patched Vite version). |
| app/Services/Webling/Letter/Template/InvoiceLetterTemplate.php | Minor header text handling adjustment while rendering invoice letters. |
| .github/workflows/tests.yml | Adds explicit default GITHUB_TOKEN permissions (least privilege). |
| .github/workflows/security.yml | Adds lockfile consistency checks and Composer/npm audit gates. |
| .github/workflows/lint.yml | Tightens default permissions; scopes write permission to the job that needs it. |
| .github/workflows/e2e.yml | Updates third-party action versions used for report publish/commenting. |
| .github/workflows/deploy.yml | Pins deploy actions to tagged versions and tightens workflow permissions. |
| .github/dependabot.yml | Simplifies Dependabot config; keeps grouped updates by semver impact. |
| .github/copilot-instructions.md | Updates repository Copilot guidance (incl. Laravel major version and skills list). |
| .github/skills/pr-description/SKILL.md | Formatting/cleanup of skill documentation content. |
| .github/skills/pest-testing/SKILL.md | Expands Pest syntax guidance to include test() as well as it(). |
| .github/skills/livewire-development/SKILL.md | Clarifies Livewire v4 component generation formats and conventions. |
| .github/skills/laravel-best-practices/SKILL.md | Adds a consolidated Laravel best-practices skill definition. |
| .github/skills/laravel-best-practices/rules/validation.md | Adds validation best-practices reference content. |
| .github/skills/laravel-best-practices/rules/testing.md | Adds testing best-practices reference content. |
| .github/skills/laravel-best-practices/rules/style.md | Adds conventions/style best-practices reference content. |
| .github/skills/laravel-best-practices/rules/security.md | Adds security best-practices reference content. |
| .github/skills/laravel-best-practices/rules/scheduling.md | Adds scheduling best-practices reference content. |
| .github/skills/laravel-best-practices/rules/routing.md | Adds routing/controller best-practices reference content. |
| .github/skills/laravel-best-practices/rules/queue-jobs.md | Adds queue/job best-practices reference content. |
| .github/skills/laravel-best-practices/rules/migrations.md | Adds migration best-practices reference content. |
| .github/skills/laravel-best-practices/rules/mail.md | Adds mail best-practices reference content. |
| .github/skills/laravel-best-practices/rules/http-client.md | Adds HTTP client best-practices reference content. |
| .github/skills/laravel-best-practices/rules/events-notifications.md | Adds events/notifications best-practices reference content. |
| .github/skills/laravel-best-practices/rules/error-handling.md | Adds error-handling best-practices reference content. |
| .github/skills/laravel-best-practices/rules/eloquent.md | Adds Eloquent best-practices reference content. |
| .github/skills/laravel-best-practices/rules/db-performance.md | Adds DB performance best-practices reference content. |
| .github/skills/laravel-best-practices/rules/config.md | Adds configuration best-practices reference content. |
| .github/skills/laravel-best-practices/rules/collections.md | Adds collection best-practices reference content. |
| .github/skills/laravel-best-practices/rules/caching.md | Adds caching best-practices reference content. |
| .github/skills/laravel-best-practices/rules/blade-views.md | Adds Blade/view best-practices reference content. |
| .github/skills/laravel-best-practices/rules/architecture.md | Adds architecture best-practices reference content. |
| .github/skills/laravel-best-practices/rules/advanced-queries.md | Adds advanced query patterns reference content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes the open GitHub security findings, refreshes PHP and npm dependencies, and hardens CI/security automation so updates and checks are more reliable across platforms.
Details
querySelectorusage with safe ID lookup to resolve the CodeQL DOM-XSS finding.vite@8.0.9for Dependabot advisories.Notes
.github/skillsand.github/copilot-instructions.mdtriggered by dependency updates.Reviewer Setup
In this PR vs
origin/main, changes were made in dependencies, CI workflows, and frontend assets. You likely need to run: