Conversation
Both classes expose a size/pending property but lack the standard __len__ dunder. Adding it makes len() work naturally, which is what most Python code reaches for when checking buffer occupancy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both and expose a / property for checking occupancy, but neither implements . This means raises even though the intent is obvious.
This adds the standard dunder to both classes, delegating to the existing internal collections. is the idiomatic Python way to check container size, and having it work makes the streaming primitives feel more like standard library types.
Tests in verify the dunder matches the existing property for both classes across push/pop/append/take operations.