Conversation
Passing an empty boundaries tuple silently puts all sequences into bucket 0, which is surprising and almost certainly a caller mistake. Explicitly reject this case with a clear error message.
Owner
|
I checked There is an API behavior decision to settle before merging. Currently, Could you describe a caller case that requires rejecting this configuration and document the intended behavior, including when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When receives an empty tuple or list, it silently places all sequences into bucket 0 (the overflow bucket). This is almost certainly a mistake by the caller - why call a bucketing function with no buckets?
The existing validation () passes for empty lists since . This adds an explicit check before the sorted check, raising a clear "boundaries cannot be empty" error.
Added regression tests in covering both tuple and list empty inputs.