test(tokens): cover encode_text without boundaries, decode_text error policies, and modality edge values - #19
Open
lcampb96 wants to merge 1 commit into
Conversation
… policies, and modality edge values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing token tests focus heavily on UTF-8 roundtrip with
boundaries=Truebut leave several paths uncovered. This adds eight tests:encode_textwithboundaries=Falseomits BOS/EOS markersencode_textbyte offset verification (null byte encodes as ID 4)decode_textwitherrors=replacesubstitutes invalid bytes with U+FFFDdecode_textwitherrors=ignoresilently drops invalid bytesmodality(4)correctly classifies the first text tokenmodality(259)correctly classifies the last text token before the audio rangemodality(260)correctly classifies the first audio tokenencode_text(, False)yields an empty listAll 63 tests pass locally (
pytest tests/test_tokens.py -q).