Skip to content

test(conversation): add tests for save validation, custom vocabulary size, and empty file loading - #20

Open
fabihy wants to merge 1 commit into
fufuchiu:mainfrom
fabihy:test-conversation-save-validation
Open

fabihy wants to merge 1 commit into
fufuchiu:mainfrom
fabihy:test-conversation-save-validation

Conversation

@fabihy

@fabihy fabihy commented Sep 10, 2026

Copy link
Copy Markdown

Five additional tests for conversation.py:

  • save_conversations raises before writing when turns are invalid (file is not created)
  • validate_example with custom vocabulary_size rejects out-of-range target IDs
  • A user Turn can carry both text and audio simultaneously
  • load_conversations with an empty file returns an empty list
  • A single user turn is a valid conversation prefix

All 33 tests pass locally (pytest tests/test_conversation.py -q).

@fabihy
fabihy requested a review from fufuchiu as a code owner September 10, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant