fix(streaming): require terminal event in validate_events - #9
Merged
Merged
Conversation
The docstring promises 'a single final terminal event' but the function accepted empty lists and sequences ending with non-terminal events. Add explicit checks for both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring for
validate_eventsinsrc/speechloom/streaming.pypromises to "require contiguous sequence IDs and a single final terminal event", but the implementation silently accepted:[]passes without error.[StreamEvent(0, "text", "hello")]passes even though it lacks adoneorcancelledevent at the end.This adds two explicit checks:
if not valuesrejects empty lists.if values[-1].kind not in ("done", "cancelled")rejects sequences that do not end with a terminal event.A new test file
tests/test_validate_events_terminal.pycovers both cases plus the valid done and cancelled terminal paths.