Create 6. Zigzag Conversion.md#57
Open
fuga-98 wants to merge 1 commit into
Open
Conversation
oda
reviewed
Jun 1, 2025
| - 二次元のほうがジグザグを作っている感じがあって好みかなあ。 | ||
| - "".join(c for row_chars in rows for c in row_chars) | ||
|
|
||
| こう書けるらしい。少し読みにくく感じたのですが、許容ですかね。 |
There was a problem hiding this comment.
はじめてみる文法があったら、一応、公式ドキュメントをあたっておきましょう。
https://docs.python.org/3/reference/expressions.html#generator-expressions
skypenguins
reviewed
Jun 3, 2025
| class Solution: | ||
| def convert(self, s: str, numRows: int) -> str: | ||
| s_length = len(s) | ||
| zigzag = [['' for _ in range(len(s))] for _ in range(numRows)] |
skypenguins
reviewed
Jun 3, 2025
Comment on lines
+125
to
+139
| def move_down(index): | ||
| row = 0 | ||
| while index < len(s) and row < numRows: | ||
| zigzag[row].append(s[index]) | ||
| row += 1 | ||
| index += 1 | ||
| return index | ||
|
|
||
| def move_up(index): | ||
| row = numRows - 2 | ||
| while index < len(s) and row > 0: | ||
| zigzag[row].append(s[index]) | ||
| row -= 1 | ||
| index += 1 | ||
| return index |
There was a problem hiding this comment.
現在位置の移動を関数化して切り出しているのは読みやすいと感じました。
変数 column を取り除いているので好みの問題ですが、 move_up だと垂直移動を想起するので mode_up_diagonallyでも良いかと思いました。
Owner
Author
There was a problem hiding this comment.
これ関数の実体に合わせるか、やりたいことに合わせるか迷いました。
|
いいと思いました。60問お疲れ様でした！ |
nodchip
reviewed
Jun 15, 2025
| row -= 1 | ||
| column += 1 | ||
| return s_i, column | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/zigzag-conversion/