feat(config_httpd): add CONFIG_ML_CONFIG_HTTPD toggle, fix peer-update queue depth - #51
Merged
Merged
Conversation
…e queue depth CONFIG_ML_CONFIG_HTTPD (default y) gates only the port-80 httpd task start; ml_config_httpd_init() still loads NVS settings regardless, so a provisioned device is unaffected with it off, saving ~7-8KB of internal RAM on RAM-tight boards. ML_PEER_UPDATE_QUEUE_DEPTH was an underived 400, allowing a theoretical ~80KB internal-RAM burst of in-flight peer-update payloads. 32 (4x runtime max_peers=8) caps that burst at ~6.6KB. Adapted from antmanler/microlink@6ef9f5a0 — same logic/comments, hand- ported rather than cherry-picked since the diff no longer applies cleanly after PR #47's teardown rewrite shifted surrounding lines. Closes #27 Co-authored-by: Adrian.Nguyen-Qualgo <nguyen.ndt@qualgo.net> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONFIG_ML_CONFIG_HTTPDKconfig option (defaulty) gates only the port-80 config webserver task start —
ml_config_httpd_init()still loads NVS settings unconditionally, so aprovisioned device behaves identically with it off, while saving ~7-8KB of internal RAM on
RAM-tight boards.
ML_PEER_UPDATE_QUEUE_DEPTHwas an underived400, allowing a theoretical ~80KB internal-RAMburst of in-flight peer-update payloads. Dropped to
32(4x the runtimemax_peers=8), cappingthe burst at ~6.6KB.
antmanler/microlink@6ef9f5a0— same logic and comments as the source commit. Not aliteral cherry-pick:
git apply --check --3wayfailed on unrelated line-number drift from PR fix(microlink): worker task liveness bitmask, orphan-parked teardown #47'steardown rewrite (not a real conflict), so this was hand-ported instead.
Closes #27
Test plan
idf.py buildnot runnable in this sandbox (no ESP-IDF installed) — needs a real build withCONFIG_ML_CONFIG_HTTPD=nto confirm the httpd task is actually skipped and NVS-provisionedsettings (WiFi creds, priority peer, ctrl host, debug flags) still load and apply correctly.
CONFIG_ML_CONFIG_HTTPD=y(default) preserves current behavior exactly.🤖 Generated with Claude Code