docs(fork-prs): mark #39 decided-not-to-port - #79
Merged
Conversation
ip4_route_src_hook would force tailnet-range traffic onto the WG netif directly. Already assessed as likely redundant (lwIP's ip4_route() scans netif_list for a netmask match before ever consulting LWIP_HOOK_IP4_ROUTE_SRC, and wg_init_interface() already registers the WG netif with the correct /10 netmask) -- the one open question was a possible edge case during microlink_rebind() netif flapping. Re-read microlink_rebind() directly: it never touches the WG netif's link state at all, only closes/reopens DISCO/STUN sockets and signals coord+DERP to reconnect. The netif is only ever netif_remove()'d once, in ml_wg_mgr_task's shutdown path (full stop/destroy, not rebind). So the netif stays continuously up and registered for its entire lifetime outside of full teardown -- the edge case doesn't exist. No scenario left where the hook would change behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ip4_route_src_hook(djorr5/microlink's67b230b2, piece (b) — piece (a) was issue #38, already landed) would force tailnet-range traffic onto the WG netif directly viaLWIP_HOOK_IP4_ROUTE_SRC.Already assessed as likely redundant in an earlier session: lwIP's own
ip4_route()scansnetif_listfor a netmask match before ever consulting the hook, andwg_init_interface()already registers the WG netif directly intonetif_listwith the correct/10netmask — so the hook's logic duplicates what already happens. The one thing left open was a possible edge case: "netif up/link-up flapping during rebind."This session closed that gap by reading
microlink_rebind()directly (microlink.c:669-730): it never touches the WG netif's link state at all — only closes/reopens the DISCO/STUN sockets and signals coord+DERP to reconnect. The netif is only evernetif_remove()'d once, inml_wg_mgr_task's shutdown path (fullmicrolink_stop()/destroy(), not rebind). So the netif stays continuously registered and up innetif_listfor its entire lifetime outside of full teardown — the edge case the earlier assessment left open doesn't actually exist in this fork. No scenario remains where the hook would change behavior.No code change — closing FORK_PRS.md's tracking as decided-not-to-port (distinct from "not yet done").
Test plan
N/A — documentation only, no code/build impact.
Closes #39
🤖 Generated with Claude Code