build: replace wireguard_lwip symlink chain with a clean submodule - #8
Merged
Conversation
components/wireguard_lwip was a symlink into a vendored copy nested inside components/microlink/components/wireguard_lwip -- a diverged copy of a diverged copy with no git blame back to the original author (Daniel Hope, smartalock/wireguard-lwip, BSD-3-Clause). That vendored copy has now been re-forked as a real GitHub fork, fugo101/wireguard-lwip, with FuGo's changes replayed as clean Conventional Commit PRs on top of upstream history. Point at it directly as a submodule instead: no more symlink, no more nested nameless copy, and git log/blame now resolves to the real author for every line that hasn't changed. examples/*/CMakeLists.txt needs no changes -- EXTRA_COMPONENT_DIRS still finds both components/microlink and components/wireguard_lwip one level deep, exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the symlink → nested vendored copy of wireguard_lwip with a clean
submodule pointing at fugo101/wireguard-lwip -- a real fork of
smartalock/wireguard-lwip with FuGo's changes replayed as Conventional
Commit PRs on top of upstream history (see fugo101/wireguard-lwip#1-#6).
No functional change:
EXTRA_COMPONENT_DIRS "../../components"in everyexample still finds both components/microlink and components/wireguard_lwip
one level deep, exactly as before.
PRIV_REQUIRES wireguard_lwipincomponents/microlink/CMakeLists.txt is unchanged (short component name,
not the registry-mangled name -- the component manager rewrites this at
build time regardless of source).
Part of the microlink registry migration (fugo101/microlink is being
prepared to publish on the ESP Component Registry).