fix(remote): bound sync readiness by wall clock - #839
Draft
pennywise1026-eng wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Bound
remote.sh sync startreadiness polling by both its existing attempt ceiling and a wall-clock budget. The defaults preserve the documented approximately 16-second wait;AGMSG_SYNC_READY_TRIESandAGMSG_SYNC_READY_SECONDSpermit explicit test control.Why
The previous 1600-iteration loop also ran process status, tail, awk, and sleep on every turn. On slow Windows/Git Bash filesystems it could take roughly two minutes rather than the documented wait. A late or missing ready marker should cost only this caller its intended time budget.
Validation
git diff --checkandbash -n scripts/remote.shpass.Refs #779