fix(resolve): map grok-build to grok in the pid walk - #860
Open
apstndb wants to merge 2 commits into
Open
Conversation
Without this arm, grok-build falls through to claude/codex/gemini, so agmsg_agent_pid never sees a live grok and watchers are not liveness-gated. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 17, 2026
…ibee#856) Homebrew grok-build and the Cursor CLI installer both ship `agent`. Listing it on either type would attach the wrong pid (fujibee#93). Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #859.
_agmsg_agent_binarieshas nogrok-buildarm, so the type falls through toclaude codex geminiand grok-build watchers are not liveness-gated.Independently mergeable. Split out of #856 because cursor monitor only needs the
cursor-agentarm. Readingdetect_procfrom the manifest stays #631.Do not list
agent(Homebrew grok-build and the Cursor CLI installer share that basename). The policy is on #856; this PR comments the omission.#858 stays a draft until this and #857 have landed.
Test plan
bats tests/test_resolve_project.bats --filter agent-binariesbats tests/test_resolve_project.bats