Skip to content

test(compat): make the space-in-path premise able to fail (unblocks main) #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fujibee wants to merge 1 commit into from
Closed

test(compat): make the space-in-path premise able to fail (unblocks main) #888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/test_compat_posix.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,11 @@ _stub_ps_printing() {
esac

# The real ps hands us a path with a space -- the premise of the stub above.
[[ "$raw" == *"Application Support"* ]]
# grep, not `[[ ]]`: a non-last `[[ ]]` cannot fail a test on bash 3.2 (#670),
# and a premise that cannot fail is worse than no premise -- the assertions
# below would still run, against a `raw` that never had the shape they are
# about.
grep -qF -- 'Application Support' <<<"$raw"

run compat_get_comm "$_PROC_PID"
[ "$status" -eq 0 ]
Expand Down
Loading