chore(contracts): CHAOS-5720 Re-derive the ACR contract mirror for the organization-scope basis - #72
Merged
Merged
Conversation
…e organization-scope basis
…e refusal basis vocabulary
…cer's current tip
…cer tip whose refusal sentences carry no basis token
…cer's merge commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CHAOS-5720
TEST-EVIDENCE
Re-derives the ACR contract mirror so this workbench accepts the refusal basis
organization_scope_unsupportedthat the producer now serves.refusal_basisgains a 6th closed-vocabulary member. The producer serves it when a question makes the organization itself the subject and asks for something other than a count, and it ends without a committed subject. The result carries the basis's own fixed sentence, which says organization-wide analysis of status, health or drivers is not supported and organization-wide counts are. On the prior pin, a response carrying the value is rejected asacr_contract_violationat/refusal_basisand/completeness/refusal_basis.Branch
chore/5720-org-scope-basis-mirroroffmain2b8e70d7, 3 commits, all signed (tipf84efea301c7511b09020e2c5f9697d9bb12864d). Every command below was executed in this worktree after a realpnpm install --frozen-lockfile(rc=0;node_modulesinstalled, not linked).git diff --numstat fe3fe467 64d9cfa8over all ten mirrored ACR files gives+2/-1incontext_fabric_common.v1.schema.jsonand+2/-1incontext_fabric_investigation_result.v1.schema.json. Every other file is unchanged, so this PR carries the one member and nothing else from ACR.SOURCE_COMMITis ACR64d9cfa866da0e460ec92fbe4604e8a6d82b4412, the producer change's tip. It is provisional and is re-pinned to the producer's merge commit before this merges.node scripts/sync-acr-contracts.mjs generate --allow-write --source <acr worktree parked on 64d9cfa8>rc=0. The script is the only author of every generated artifact.node scripts/sync-acr-contracts.mjs check --source <that worktree>→ACR contracts are current.node scripts/sync-acr-contracts.mjs check→ACR contracts are current.This is the form CI runs.vitest run:next buildtail:Consumer pin. The new describe block follows the pattern of the previous member:
organization_scope_unsupported_,ORGANIZATION_SCOPE_UNSUPPORTED,organization_scope);completeness.refusal_basis;declared_kind_unmatched.The existing continuation-refusal block's vocabulary-length assertion moves from 5 to 6.
User-facing wording. The service's sentence renders verbatim. A new
DeterministicAnswerViewtest gives ano_matchresult carryingrefusal_basis: organization_scope_unsupportedand that sentence. It asserts the sentence, including "organization-wide counts", is visible text under the Limitations heading.RISK-NOTES