chore(contracts): CHAOS-5672 Re-derive the ACR contract mirror for the semantic reading disclosure - #73
Merged
Conversation
chrisgeo
force-pushed
the
chore/5672-semantic-reading-mirror
branch
from
September 13, 2026 17:12
1f9733a to
e932383
Compare
…e semantic reading disclosure
…cer's current tip
…cer tip rebased onto the role-decision fix
…cer tip rebased onto main
chrisgeo
force-pushed
the
chore/5672-semantic-reading-mirror
branch
from
September 13, 2026 17:37
e932383 to
e438e0c
Compare
…cer tip with the read side's precedence fix
…cer tip with the re-anchored result route
…cer's merge commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CHAOS-5672
TEST-EVIDENCE
Re-derives the ACR contract mirror so this workbench accepts, and renders, the optional
semantic_readingdisclosure the producer now serves. ACR sets it on a result-by-id read of a stored clarification whose check against its stored reading of the question could not run, because that reading could not be loaded.statusisunavailable, andreasonissemantic_state_absentorsemantic_state_unreadable. On the prior pin the result schema is closed, so a by-id response carrying the field is a contract violation.Branch
chore/5672-semantic-reading-mirroronmaine7f27cb, which carries the organization-scope mirror at ACR74d8fc4c(tipb20e9ca2c18341dc8b548a86fabd839059e9bd70, signed). Every command below ran in this worktree after a realpnpm install --frozen-lockfile.git diff --numstat 74d8fc4c 9e35fe94over the ten mirrored ACR files:Only the result v1 schema changes: the one optional property.
SOURCE_COMMITis ACR9e35fe9405d70879ed41600f3e4f484aea6411b2, the producer change's squash commit on ACRmain.node scripts/sync-acr-contracts.mjs generate --allow-write --source <acr worktree parked on 9e35fe94>rc=0.check --source <that worktree>andcheckboth printACR contracts are current.vitest run:next buildtail:Consumer pin. The new describe block in
src/lib/acr/validate.test.tschecks:pre_semantic_state), a missing member, an extra key and a non-object are each rejected;Rendering.
SemanticReadingNoticerenders a visible note in the clarification view when the field is present, with a reason-specific cause: the options could not be checked, and asking again starts a fresh investigation.DeterministicAnswerView.test.tsxasserts the note's visible text for each reason, and no note when the field is absent.RISK-NOTES
mains; this branch is the last of the four.