docs(adr): amend ADR 48 for dispatch version-skew and migration#2453
docs(adr): amend ADR 48 for dispatch version-skew and migration#2453rh-hemartin wants to merge 1 commit into
Conversation
Document the reusable-dispatch.yml hardcoded @v0 gap, the release-branch solution, and the backwards-compatible input alias strategy for transitioning from fullsend_ai_ref/fullsend_version to the new names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Hector Martinez <hemartin@redhat.com>
PR Summary by QodoAmend ADR 48 with dispatch version-skew notes and migration strategy Description
Diagram
High-Level Assessment
Files changed (2)
|
Site previewPreview: https://a2ace8bd-site.fullsend-ai.workers.dev Commit: |
Code Review by Qodo
1. ADR 0048 Consequences rewritten
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| * `v0` should be migrated to the new moving tag and deleted. | ||
| * Current users track the new floating tag automatically to keep behavior consistent. | ||
| * ~~Current users track the new floating tag automatically to keep behavior consistent.~~ | ||
| * Current users have a period of transition in which version to track, after a while we introduce | ||
| breaking changes to the workflows. |
There was a problem hiding this comment.
1. Adr 0048 consequences rewritten 📜 Skill insight § Compliance
docs/ADRs/0048-automatic-updates.md is an already Accepted ADR, but the PR changes the meaning of a Consequences bullet (replacing the original outcome with a new transition/breaking-changes statement). Accepted ADR sections should only receive minor annotations/cross-references, not substantive content rewrites.
Agent Prompt
## Issue description
ADR 0048 is `Accepted`, but the PR substantively changes the Consequences section by striking the original consequence and adding a new one that changes the historical record.
## Issue Context
The ADR file explicitly states that accepted ADRs should not have their Context/Decision/Consequences substantially rewritten; only minor annotations (cross-references, short notes, clarifications) are allowed.
## Fix Focus Areas
- docs/ADRs/0048-automatic-updates.md[58-66]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
🤖 Finished Review · ✅ Success · Started 9:25 AM UTC · Completed 9:47 AM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsHigh
Medium
Low
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| their shims. Rejected. | ||
| * Update `v0` a last time to these changes. This would mean that workflows would | ||
| need to preserve behaviour. Accepted, more details below. | ||
|
|
There was a problem hiding this comment.
[medium] internal-consistency
The fallback snippet uses fullsend_cli_ref and fullsend_actions_ref as primary input names, but downstream stage workflows only accept fullsend_version and fullsend_ai_ref. The plan does not document updating stage workflow input declarations.
Suggested fix: Add an explicit step noting that all reusable-{stage}.yml workflow input declarations must be updated to accept the new input names before the release-branch process is executed.
| 1. Make changes to `reusable-dispatch.yml` to change defaults values for `fullsend_actions_ref`, | ||
| `fullsend_cli_ref`, `fullsend_ai_ref` and `fullsend_version` from `v0` to `${VERSION}`. | ||
| 1. Commit the changes to the branch. | ||
| 1. Tag the branch with `${VERSION}` and `latest`. |
There was a problem hiding this comment.
[low] edge-case-correctness
The release procedure does not mention force-pushing the latest tag, which will fail on subsequent releases because latest already exists on the remote.
Suggested fix: Clarify step 7/8 to specify that the latest tag must be force-pushed.
|
|
||
| * `v0` should be migrated to the new moving tag and deleted. | ||
| * Current users track the new floating tag automatically to keep behavior consistent. | ||
| * ~~Current users track the new floating tag automatically to keep behavior consistent.~~ |
There was a problem hiding this comment.
[low] internal-consistency
The original ADR consequence is struck through and replaced with materially different text, which is borderline with the ADR policy of not substantially rewriting Consequences sections.
|
|
||
| * `v0` should be migrated to the new moving tag and deleted. | ||
| * Current users track the new floating tag automatically to keep behavior consistent. | ||
| * ~~Current users track the new floating tag automatically to keep behavior consistent.~~ |
There was a problem hiding this comment.
[low] amendment-annotation-style
The (added 2026-06-19) annotation format and strikethrough markdown are novel in this codebase's ADR corpus. No other ADR uses either pattern.
| fullsend_cli_ref: v0.15.0 | ||
| ``` | ||
|
|
||
| ## 2026-06-19 amendments |
There was a problem hiding this comment.
[low] adr-amendment-scope
74 lines of new content with design decisions and rejected alternatives added to a plan document. The volume and ADR-style language suggest these decisions could warrant a separate ADR.
| fullsend_cli_ref: v0.15.0 | ||
| ``` | ||
|
|
||
| ## 2026-06-19 amendments |
There was a problem hiding this comment.
[low] design-coherence
The amendments use ADR-style rejected/accepted language for options, which is stylistically unusual for a plan document.
1 participant
Summary
reusable-dispatch.ymlhardcoded@v0problem for per-repo version pinningyqfullsend_ai_ref/fullsend_versionto new namesTest plan
🤖 Generated with Claude Code