Skip to content

chore: update fullsend shim workflow #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-fullsend wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

chore: update fullsend shim workflow #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/fullsend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# This file is managed by fullsend. Do not edit it directly.

@fullsend-ai-review fullsend-ai-review Bot Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] comment-style

The management barrier comments introduce a new comment pattern not present elsewhere in the repository. This appears to be a convention from an external template rather than an established repository pattern.

# Upstream: https://github.com/fullsend-ai/fullsend/blob/main/internal/scaffold/fullsend-repo/templates/shim-workflow-call.yaml
---

@fullsend-ai-review fullsend-ai-review Bot Jun 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] yaml-formatting

The added YAML document separator (---) is inconsistent with existing workflow files in the repository. collect.yml and holidays.yaml do not use document separators.

@fullsend-ai-review fullsend-ai-review Bot Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] yaml-formatting

The added YAML document separator is inconsistent with existing workflow files. The other workflow file (collect.yml) and YAML files (holidays.yaml) do not use document separators. However, since this file is managed by an external template, enforcing local style consistency may conflict with the upstream template.

# --- fullsend managed below - do not edit ---

@fullsend-ai-review fullsend-ai-review Bot Jun 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] comment-style

The management barrier comment introduces a new comment pattern not present elsewhere in the repository.

# lint-workflow-size: max-lines=280
# fullsend shim workflow (workflow_call mode)
# Routes events to agent workflows in .fullsend via workflow_call.
Expand Down Expand Up @@ -44,7 +48,6 @@ jobs:
uses: fullsend-ai/.fullsend/.github/workflows/dispatch.yml@main
with:

@fullsend-ai-review fullsend-ai-review Bot Jun 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] code-analysis

The removal of secrets: {} is a no-op change. Both forms are functionally equivalent in GitHub Actions.

@fullsend-ai-review fullsend-ai-review Bot Jun 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] code-style

Removing secrets: {} eliminates an explicit empty-allowlist annotation. This is a style preference, not a security concern.

event_action: ${{ github.event.action }}
secrets: {}

@fullsend-ai-review fullsend-ai-review Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] code-analysis

The removal of secrets: {} from the dispatch job reusable workflow invocation is a no-op change. In GitHub Actions, omitting the secrets key and passing secrets: {} are functionally equivalent. No correctness, security, or behavioral impact.

@fullsend-ai-review fullsend-ai-review Bot Jun 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] code-analysis

The removal of secrets: {} from the dispatch job's reusable workflow invocation is a no-op change. In GitHub Actions, omitting the secrets key and passing secrets: {} are functionally equivalent — both forward zero secrets to the called workflow. The workflow header comment confirms agents use OIDC tokens, not forwarded secrets. No correctness, security, or behavioral impact.

@fullsend-ai-review fullsend-ai-review Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] code-analysis

The removal of secrets: {} from the dispatch job reusable workflow invocation is a no-op change. In GitHub Actions, omitting the secrets key and passing secrets: {} are functionally equivalent — both forward zero secrets to the called workflow. The workflow header comment confirms agents use OIDC tokens, not forwarded secrets. No correctness or behavioral impact.

@fullsend-ai-review fullsend-ai-review Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] code-style

Removing secrets: {} eliminates an explicit empty-allowlist annotation. Both forms are functionally identical in GitHub Actions — no secrets are forwarded unless secrets: inherit is used. The explicit form had marginal value as a documentation signal of intent, but this is a style preference, not a security concern.

stop-fix:
if: >-
Expand Down
Loading