Update GetModels action and related configurations#117
Update GetModels action and related configurations#117tcampbPPU merged 11 commits intofumeapp:masterfrom
Conversation
|
oh interesting, thanks for the PR i will look over and review! |
|
Hi, Pint is failing because you should run "composer pint" before committing, but this can be configured to work on push, but it need "Read and write permissions", from laravel docu, also there is no need for running it multiple times, maybe change the php version to minimum php8.2 |
yea locally it was telling it was fine bc i didn't upgrade my local pint dep 🙄, i don't do a ton of php anymore so i often dont upgrade them lol |
This pull request tries to solve a problem I’m having when working on Windows and Mac, for some reason the order of models being returned by
GetModels.phpchanges based on the OS.So when I’m at my windows pc I get interfaces alphabetically ordered, and on mac (I don’t know, by folder name?), this produces changes on git that are not real.
Solution, sort the resulting collection by class name.
But then I noticed that is really hard to understand what
GetModels.phpis actually doing, so I change the order of thing to be more Laravel like, and added missing types.Run pint to fix error present in codebase (from other pull requests) and change workflows to fail on pull requests not properly formatted.
Update
GetModelsTest.php.