Skip to content

Moved property type definition for "target_source"#240

Open
Adrihfu wants to merge 1 commit into
func-godot:mainfrom
Adrihfu:patch-1
Open

Moved property type definition for "target_source"#240
Adrihfu wants to merge 1 commit into
func-godot:mainfrom
Adrihfu:patch-1

Conversation

@Adrihfu
Copy link
Copy Markdown

@Adrihfu Adrihfu commented Apr 12, 2026

Related to this issue #215
where Godot saves the Object Variant Type has an null in file when empty.

Changing the type fixes it.

It was moved from TYPE_OBJECT to TYPE_STRING_NAME, which was not been used and fits the use of target_source.

… to TYPE_STRING_NAME

Related to a problem where Godot saves the Object Variant Type has an null in file when empty.

Changing the 'target_source' type check solves it.
@suhankins
Copy link
Copy Markdown
Contributor

TYPE_STRING_NAME is used as StringName. I.e. if I have an object with property action that takes StringName, I'd need to set action in my FGD config to be StringName

@Adrihfu
Copy link
Copy Markdown
Author

Adrihfu commented Apr 12, 2026

TYPE_STRING_NAME is used as StringName.

Inside the func_godot_fgd_entity_class.gd script StringName was not been check.

I.e. if I have an object with property action that takes StringName, I'd need to set action in my FGD config to be StringName

By default StringName is not been added to the FGD because is not been check in the func_godot_fgd_entity_class.gd.
temp
temp2

You mean that a class or script that you are using recieves a StringName variable named action, right?

@suhankins
Copy link
Copy Markdown
Contributor

You mean that a class or script that you are using recieves a StringName variable named action, right?

I was wrong about how it would work, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants