Skip to content

Ensure git clone base directory exists on startup #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
creydr merged 1 commit into from
Apr 29, 2026
Merged

Ensure git clone base directory exists on startup #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,12 +348,18 @@ func main() {
}
setupLog.Info("Func CLI is ready")

gitManager, err := git.NewManager()
if err != nil {
setupLog.Error(err, "failed to initialize git manager")
os.Exit(1)
}

if err := (&controller.FunctionReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Recorder: mgr.GetEventRecorder("functions-controller"),
FuncCliManager: funcCLIManager,
GitManager: git.NewManager(),
GitManager: gitManager,
OperatorNamespace: operatorNamespace,
}).SetupWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "Function")
Expand Down
7 changes: 5 additions & 2 deletions internal/git/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@ type Manager interface {
CloneRepository(ctx context.Context, url, subPath, reference string, auth map[string][]byte) (*Repository, error)
}

func NewManager() Manager {
return &managerImpl{}
func NewManager() (Manager, error) {
if err := os.MkdirAll(cloneBaseDir, 0755); err != nil {
return nil, fmt.Errorf("failed to create git clone base directory: %w", err)
}
return &managerImpl{}, nil
}

type managerImpl struct{}
Expand Down
Loading