fix: return error on invalid SSH private key instead of silent nil#151
Closed
creydr wants to merge 1 commit into
Closed
fix: return error on invalid SSH private key instead of silent nil#151creydr wants to merge 1 commit into
creydr wants to merge 1 commit into
Conversation
When gitssh.NewPublicKeys failed (e.g. corrupted key), getSSHClientOptions silently returned nil, causing the clone to proceed without authentication and fail with a confusing error. Now the key parse error is propagated through getClientOptions to CloneRepository, giving users a clear "failed to parse SSH private key" message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitssh.NewPublicKeysfailed (e.g. corrupted/invalid key),getSSHClientOptionssilently returnednil, causing the clone to proceed without authentication and fail with a confusing errorgetSSHClientOptionsandgetClientOptionsto return([]client.Option, error)so the key parse error is propagated toCloneRepository