Fix staticcheck SA5011 false positives in function_lifecycle_test.go#56
Merged
Conversation
Add explicit return statements after t.Fatal() calls to make it clear to staticcheck that execution terminates, preventing false positive nil pointer dereference warnings. This resolves intermittent lint failures in the merge queue where staticcheck SA5011 would complain about potential nil dereferences even though t.Fatal() terminates execution.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit return statements after t.Fatal() calls to make it clear to staticcheck that execution terminates, preventing false positive nil pointer dereference warnings.
This resolves intermittent lint failures in the merge queue where staticcheck SA5011 would complain about potential nil dereferences even though t.Fatal() terminates execution.