Skip to content

[release-0.2] Add middleware version to logs #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
creydr merged 1 commit into from
Apr 22, 2026
Merged

[release-0.2] Add middleware version to logs #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/controller/function_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,8 @@ func (r *FunctionReconciler) handleMiddlewareUpdate(ctx context.Context, functio
function.MarkMiddlewareNotUpToDateIntentionally("SkipMiddlewareUpdate", "Skipping middleware update as update is disabled (source: %s)", source)
// Don't return - continue to update deployment status
} else {
logger.Info("Function is not on latest middleware and middleware update is enabled. Will redeploy")
function.MarkMiddlewareNotUpToDate("MiddlewareOutdated", "Middleware is outdated, redeploying")
logger.Info(fmt.Sprintf("Function is not on latest middleware (%q vs %q) and middleware update is enabled. Will redeploy", latestMiddleware, functionDescribe.Middleware.Version))
function.MarkMiddlewareNotUpToDate("MiddlewareOutdated", "Middleware is outdated (%s available), redeploying...", latestMiddleware)

function.Status.Middleware.PendingRebuild = true

Expand All @@ -271,7 +271,7 @@ func (r *FunctionReconciler) handleMiddlewareUpdate(ctx context.Context, functio
function.Status.Middleware.Available = nil // if function is on latest, we don't need to show this field
}
} else {
logger.Info("Function is deployed with latest middleware. No need to redeploy")
logger.Info(fmt.Sprintf("Function is deployed with latest middleware (%s). No need to redeploy", functionDescribe.Middleware.Version))
function.MarkMiddlewareUpToDate()
function.Status.Middleware.Available = nil // if function is on latest, we don't need to show this field
}
Expand Down
Loading