Skip to content

fix: Set service status in status initially too #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
creydr merged 1 commit into from
Apr 22, 2026
Merged

fix: Set service status in status initially too #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions internal/controller/function_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ func (r *FunctionReconciler) handleMiddlewareUpdate(ctx context.Context, functio
return fmt.Errorf("failed to describe function to get image details: %w", err)
}
function.Status.Deployment.Image = functionDescribe.Image
markServiceStatus(functionDescribe.Ready, function)

isMiddlewareUpdateEnabled, source, err := r.isMiddlewareUpdateEnabled(ctx, function)
if err != nil {
Expand Down Expand Up @@ -283,19 +284,22 @@ func (r *FunctionReconciler) handleMiddlewareUpdate(ctx context.Context, functio
}
function.Status.Deployment.Image = functionDescribe.Image
function.Status.Middleware.Current = functionDescribe.Middleware.Version
markServiceStatus(functionDescribe.Ready, function)

function.MarkDeployReady()

switch functionDescribe.Ready {
return nil
}

func markServiceStatus(ready string, function *v1alpha1.Function) {
switch strings.ToLower(ready) {
case "true":
function.MarkServiceReady()
case "false":
function.MarkServiceNotReady("ServiceNotReady", "Underlying service is not ready")
default:
function.MarkServiceNotReady("ServiceReadyUnknown", "Underlying service readiness is unknown")
}

return nil
}

func (r *FunctionReconciler) setupPipelineRBAC(ctx context.Context, function *v1alpha1.Function) error {
Expand Down
Loading