Fix the new Django admin user edit form's password change button#129
Merged
bgaudino merged 4 commits intofusionbox:masterfrom Sep 29, 2025
Merged
Conversation
At some point in the recent past (https://code.djangoproject.com/ticket/34977), Django changed the user edit form away from showing a link to the password change page, into a button. This relied on a call to `get_context()`, which this custom password widget wasn't invoking.
Contributor
Author
Contributor
Author
|
The reason for the check for the presence of the ref: https://github.com/django/django/blob/5.2.5/django/contrib/auth/forms.py#L44-L59 |
4c9d1a2 to
c2448f1
Compare
This should work both for pre-5.0 and post-5.0 versions of Django.
c2448f1 to
1019cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


At some point in the recent past
(https://code.djangoproject.com/ticket/34977), Django changed the user edit form away from showing a link to the password change page, into a button. This relied on a call to
get_context(), which this custom password widget wasn't invoking.