Add support for fwb futurization #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for this! Could you please create an issue that points to this PR? I've missed, forgotten about PR-only contributions in the past. |
HenrikBengtsson
requested changes
Jan 24, 2026
R/addons-fwb.R
Outdated
|
|
||
| template <- quote( | ||
| local({ | ||
| oopts <- options(future.ClusterFuture.clusterEvalQ = "error") |
Collaborator
There was a problem hiding this comment.
Option future.ClusterFuture.clusterEvalQ is only used when future::makeClusterFuture() is involved. It looks like you're using pbapply, which uses future.apply internally, so there's no need for this.
Collaborator
There was a problem hiding this comment.
And because of that, there is not restriction on R (>= 4.4.0).
Author
There was a problem hiding this comment.
Got it, the change should be made!
Collaborator
There was a problem hiding this comment.
You can drop the local({ ... }) wrapper too
Collaborator
There was a problem hiding this comment.
You can drop the local({ ... }) wrapper too
Author
|
Mentioned in #4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Henrik, This is a really cool project, and I wanted to help expand the available functions that could be
futurized. I added support for my R package fwb, which is basically a drop-in for boot. This isn't really the best use case because parallelization is as simple as settingcl = "future"in the package's function calls, but I thought this would be a good excuse to better understand the package in case I make some additional contributions.I added fwb to most of the relevant documentation (wherever boot was mentioned), including the Description and README, and I added some tests. I didn't update the NEWS or give it its own vignette; I figured you could pretty much copy the boot vignette or even add fwb to it.
Noah