fix: report dropped segments when sanitizing folder paths#218
Merged
Conversation
ClipRepository.SanitizeFolderPath now logs a warning naming the dropped segments and what was kept, and raises FolderPathSanitized so the host can surface a non-blocking notice. The save flow in MainWindowViewModel captures these notices and appends a sanitized suffix to the final status, so programmatic placements that landed somewhere other than requested are visible to the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClipRepository.SanitizeFolderPathnow logsLog.Warnnaming the dropped segments and what was kept whenever it discards./../whitespace segments.FolderPathSanitizedevent onClipRepositorycarries the original path, the sanitized path, and the dropped segments.MainWindowViewModel.SaveClipsStorageAsyncsubscribes around the save and appends; sanitized N folder path(s) — see log for dropped segmentsto the final status when sanitization fired, so plugin-driven or user-typed placements that landed somewhere unexpected are visible.Date/Time) do not trigger the warning — that's a reversible round-trip, not a drop.