fix: resolve PR #168 merge issues in shared RL utilities - #174
Closed
Hecate0821 wants to merge 1 commit into
Closed
Hecate0821 wants to merge 1 commit into
Hecate0821 wants to merge 1 commit into
Conversation
PR #168 (FrozenLake example) incorrectly overwrote several shared utilities with older/incompatible versions during merge: - Restore TrainStepFns interface in train.py (reverts MinibatchTrainFns rewrite that broke rl_loop.py recipe) - Remove _install_tinker_future_retrieve_compat() from client.py (workaround no longer needed, fixed server-side) - Restore direct disable_speculative_decoding= in config.py (removes unnecessary inspect guard) - Remove grad_accum param and restore apply_shape() in infra.py - Update frozen_lake example to use TrainStepFns (1:1 loop) Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #168 (FrozenLake example) incorrectly overwrote several shared utilities with older/incompatible versions during merge:
Made-with: Cursor