Skip to content

Fix setup for agentic_rl_text2sql notebook - #700

Open
iuliaturc wants to merge 1 commit into
fw-ai:mainfrom
iuliaturc:fix/sql-agent-notebook-setup
Open

iuliaturc wants to merge 1 commit into
fw-ai:mainfrom
iuliaturc:fix/sql-agent-notebook-setup

Conversation

@iuliaturc

Copy link
Copy Markdown

Human-written PR description 🙃

These changes make the notebook runnable in one go:

  1. [critical] update the pip install list
  2. add git clone and cd bash commands so that you can just open the notebook in e.g. Colab without moving any other files manually
  3. download the BIRD dataset automatically (it takes a while to figure out the official source and where to place the files)

Note to reviewer: Github's UI makes .ipynb diff hard to read. Here's a more readable diff (made with nbdime):
diff-screenshot

- Make the Setup section runnable: pip install cell (adding the missing
  eval-protocol, chromadb, langchain_chroma, langchain_fireworks deps
  used by sql_reward.py, sql_tools.py and prepare_data.py), an API key
  cell, and cells to clone the repo and cd into this folder (e.g. for
  Colab).
- Add the missing deps to the README install instructions.
- Add a notebook cell that downloads and extracts the BIRD dev set
  (dev.json + dev_databases/) if it isn't already present, so
  prepare_data.py can run.
- Gitignore the downloaded BIRD archives.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Hecate0821

Hecate0821 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Thanks @iuliaturc — this is a great fix, and the nbdime screenshot made it easy to review. 🙌

A note on process: this repository's main is a generated mirror — it only accepts the automated promotion PR from our internal monorepo, which is why the Promotion source gate check fails on external PRs. Direct merges here would be overwritten by the next promotion.

So we've ported your changes into internal staging (with you credited via Co-authored-by), including one small adjustment on top: the setup cell now skips the git clone when the notebook already runs inside a local checkout (a re-run would otherwise fail on the existing cookbook/ directory).

Once the internal PR merges, the promotion automation will publish your changes to this repo's main automatically. We'll close this PR once that lands — your contribution will ship, just through the generated path.

@iuliaturc

Copy link
Copy Markdown
Author

Awesome, thanks for the detailed explanation of the process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants