Search for Undefined YSF Host (Use WiresX, connect to a reflector by ID, use 00000) and YSFGateway will segfault.

[MW0MWZ]

Raising this as an issue, so that I have some space to open discussion about it, along with some additional changes.

First, crash on searching for non existent YSF reflector. Simple fix, tiny issue crept in with the move from $NULL to nullptr.

While working on this, I was also trying to brute force the WiresX "frame type" field, in the hope I could find the magic to swap it to VW... still a nope on that, but what I did find was actually handy and lead to a new WiresX feature - now when you search for a room that does not exist, you get an immediate "Offline" message back to the radio rather than a time-out, better UX, this is very much like other replies with the "frame type" set differently - I'm calling it that, it's an un-documented protocol, feel free to give it a name that suits. Added comments around that so that you can see the intent etc.

Changes to variable names / small comments around WiresX logic to help anyone that is trying to read it, understand what it is doing / supposed to do, some of this is work I had done in the past, and I hope this makes more sense.

Improved the auto-detection of XLX hosts for WiresX passthrough, based on the new naming standardisation going on from DVRef.

Things I would love to fix, but are out of my abilities right now;
We can choose to act on WiresX commands or not, but either way they get forwarded to the network, I'd love to be able to choose IF they get forwarded or not.
I'd love to be able to set the user's radio to VW.

If any of you have ideas about either one speak up. (PR incoming for the above that I'll link here)

[W0CHP]

Running with this fix for 12+ hours and it works great. Selecting 00000 and other non-existent rooms/refls. works as designed. My $0.02 USD.

[MW0MWZ]

After working on YSFGateway some more, with a few different radios, a few things have become clear; There is what looks like it might be a protocol version field, it could also be for some other purpose - it needs some more investigation, but I was able to differentiate say an FT-70 from the other radios, and then reply in upper case for that radio and mixed case for anything else; As it turns out, this is quite fruitless.

SOME WiresX messages are designed to be between the gateway and the radio - such as a search, but some (Connected, Disconnected, not-found) are designed to be received by ANY radio within the footprint of the repeater - this means that while I could make some special FT-70D UPPERCASE answers, the ALL messages also needed to be 100% upper case too, and that is not consistent.

Where does this lead me, between this work, and the fact that WiresX's room list always lists the room name in UPPERCASE and no Spaces, I would suggest that YSFGateway has to follow the same model. FT-70D seems not to care about the room description, so that can stay in mixed case, spaces don't seem to be a problem in the room name field either.

Keeping the host files / upstream data source in Mixed Case also makes for a nicer experience in other areas, and then having the YSFGateway force that field to UPPER CASE when sending messages to the radio appears to be the nicest way to handle it.

Small PR to address this, along with a small note on the field I spotted that might help us to answer different radios differently in the future should be submitted shortly. The changes are small and light and should not break anything new.

[MW0MWZ]

This is working well, next up I'll work on stripping the uppercase host files related code back out, that is no longer needed with these recent changes.