Previous icns file didn't seem to be working when building on MacOS. … - #1
Open
gm5dna wants to merge 2 commits into
Open
Previous icns file didn't seem to be working when building on MacOS. …#1gm5dna wants to merge 2 commits into
gm5dna wants to merge 2 commits into
Conversation
…Here's a replacement.
gm5dna
added a commit
to gm5dna/homebrew-amateur-radio
that referenced
this pull request
Apr 17, 2026
Repoints the formula from the gm5dna fork to the canonical g8bpq/QtTermTCP repo and bumps the version to 0.81 to match the VersionString in source. Carries g8bpq/QtTermTCP#1 inline (regenerated icns + ICONS->ICON qmake fix) so the app icon actually renders; the PR remains unmerged upstream. Install step also wipes the stale build artefacts and prebuilt .app skeleton that upstream ships in the master tarball, since the bundled .qmake.stash is pinned to an older SDK and the prebuilt Info.plist has an empty CFBundleIconFile. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Here's a replacement.
Hi John,
I build this on MacOS and it's working perfectly, however the icon wasn't appearing. I've rebuild the icns file and it seems to be working fine now. Thought I'd share it in case it's helpful. No worries if not.
All the best,
Stuart
GM5DNA